Discovery: DID registration by clients #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
force-pushed
the
discovery/client-service-registration
branch
2 times, most recently
from
17a6aae to
2b59760
Compare
reinkrul
requested review from
gerardsn and
woutslakhorst
and removed request for
gerardsn
reinkrul
force-pushed
the
discovery/client-service-registration
branch
2 times, most recently
from
c910188 to
5c71ab5
Compare
reinkrul
force-pushed
the
discovery/client-service-registration
branch
from
0478cd6 to
8b553fb
Compare
woutslakhorst
requested changes
Jan 9, 2024
storage/sql_migrations/003_discoveryservice_client_registration.sql
Outdated
Show resolved
Hide resolved
gerardsn
requested changes
Jan 11, 2024
discovery/module.go
Outdated
| @@ -101,6 +116,7 @@ func (m *Module) Configure(_ core.ServerConfig) error { | |||
| } | |||
| m.serverDefinitions = serverDefinitions | |||
| } | |||
| m.httpClient = client.New(serverConfig.Strictmode, 10*time.Second, nil) | |||
There was a problem hiding this comment.
we need a default timeout in the serverConfig
There was a problem hiding this comment.
Maybe, maybe not. Time-out could be client-specific?
storage/sql_migrations/003_discoveryservice_client_registration.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Gerard Snaauw <[email protected]>
|
Changes to make things more understandable:
|
gerardsn
requested changes
Jan 12, 2024
Co-authored-by: Gerard Snaauw <[email protected]>
gerardsn
approved these changes
Jan 12, 2024
woutslakhorst
approved these changes
Jan 16, 2024
rolandgroen
added a commit
that referenced
this pull request
Jan 25, 2024
* master: (38 commits) VDR: Fix duplicate results when listing DIDs (#2743) VDR: API to list owned DIDs (#2742) VDR: Move did:nuts specific to did:nuts creator (#2735) Discovery: API to list configured Discovery Services (#2739) PKI: Adjust validation logging; OK = trace, NOK = info (#2736) Discovery: update client copy of Discovery Services (#2718) VDR: Group all DID Document management funcs in a new interface (#2737) Handle direct_post return from wallet to verifier (#2702) Bump github.com/nats-io/nats.go from 1.31.0 to 1.32.0 (#2724) Discovery: fix API of Client.Search() (#2730) Bump github.com/amacneil/dbmate/v2 from 2.10.0 to 2.11.0 (#2729) Discovery: DID registration by clients (#2709) Config: Add HTTP-client timeout (#2725) Policy: prevent nil dereference when no backend is configured (#2723) Bump github.com/nats-io/nats-server/v2 from 2.10.7 to 2.10.9 (#2721) SQL: specify lengths for VARCHAR columns to avoid different behavior with different RDBMS's (#2717) Bump golang from 1.21.5-alpine to 1.21.6-alpine (#2719) Handle authorization request from verifier by holder/wallet (#2680) Bump golang.org/x/crypto from 0.17.0 to 0.18.0 (#2716) Bump github.com/lestrrat-go/jwx/v2 from 2.0.18 to 2.0.19 (#2715) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #2711
This PR adds functionality and an API for discovery clients to register DIDs on discovery services. Presentations are automatically refreshed when they are about to expire.